Add: add previous block state to the block header #3045
Conversation
There was a problem hiding this comment.
Older version nodes will get disconnected. This will cause network protocol problems. And nothing will be able to talk to each other or sync on new update without using new version.
Please fix!!!
PS:
Also please cancel the github action, its been running for 25 mins now. And there is no timeout, its eating resources.
|
not a problem for neo, cause without this, we will hace more serious problem. |
|
Does this get sent over the network? in other words does it |
|
I think that we need first #2942 and maybe this #3037 (comment) |
We can add this later, but i wish we can have it before we release the next version, such that we can solve the state issue caused by further node update. |
I think that everything can be packed together into next release |
That is what i hope, cause otherwise we might just keep asking nodes to resync, and be careful of the node state difference. |
There was a problem hiding this comment.
It's obviously incompatible and it needs a lot of care before we can consider merging. We also need to integrate notary before doing stateroots. That's why 3.7/3.8 plans were laid out the way they are. Trying to fix everything in a single huge release can break the thing too easily.
|
Like @roman-khimov said |
|
Version=1 will definitely be needed. |
This pr focus on solving the problem of neo block state finality.
it will work along with neo-project/neo-modules#835